Skip to content

✨ start of supporting GraphQL#86

Open
rneswold wants to merge 5 commits into
v1.xfrom
use-gql-api
Open

✨ start of supporting GraphQL#86
rneswold wants to merge 5 commits into
v1.xfrom
use-gql-api

Conversation

@rneswold

@rneswold rneswold commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

This branch will be the new 1.x branch once we have the same support for the control system that 0.x has (minus the ACNET crap.)

@beauremus

beauremus commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The new code imports python_graphql_client but this package is NOT listed in pyproject.toml or setup.py dependencies.

@beauremus

Copy link
Copy Markdown
Contributor

Do we want to keep pushing on this PR. I feel like we've changed plans since this started. Technically @KitFieldhouse has been assigned this work by PIP-II.
I'm fine pushing on this, but I think we should make clear the goal and refine the approach a bit.
We've got new AI tools now 😁

Here's a summary from Qwen Coder Next:

Critical (Must Fix Before Merge)

  1. Fix _convertItem and _convertReply method signatures - missing self/@staticmethod
  2. Add python_graphql_client dependency to pyproject.toml
  3. Add input validation for device specifications
  4. Add GraphQL error handling before processing responses

High Priority (Should Fix)

  1. Add all exports
  2. Add endpoint configuration (environment variable)
  3. Add JWT validation with proper error messages
  4. Document auth requirements (how to get JWT)

Medium Priority (Should Consider)

  1. Add retry logic for network failures
  2. Implement or remove subscription client
  3. Consider adding async wrapper for sync GraphQL calls
  4. Add pagination support for future historical data queries

Lower Priority (Nice to Have)

  1. Add logging for debugging
  2. Add request/response timing metrics
  3. Document device specification format (DRF subset)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants