Repository navigation
Add callback for reporting accepted document loader #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sij411
wants to merge
9
commits into
fedify-dev:main
Choose a base branch
from
sij411:feat/backfill/report-accepted-document
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
812814a
Add public callback type
sij411 754cd94
Register callback to plural accessor
sij411 7a35599
Document accepted document callbacks
sij411 b5caf9d
Track accepted backfill responses by identity
sij411 d13429e
Test accepted document callback behavior
sij411 5bdc699
Document accepted document callback usage
sij411 3443bb7
Add accepted document callback release notes
sij411 d29b8c9
Avoid unused accepted response allocations
sij411 156f102
Add PR link to changelog
sij411 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| links: | ||
| '#1423': https://github.com/fedify-dev/fedify/issues/1423 | ||
| '#1445': https://github.com/fedify-dev/fedify/pull/1445 | ||
| --- | ||
| - Fixed ancestor discovery losing a loaded object's loader and verifier | ||
| defaults when its parsed target serializes differently from the loader | ||
| document. Rejected loads cannot transfer their defaults to embedded | ||
| targets with matching serialization. [[#1423], [#1445] by Jiwon Kwon] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| links: | ||
| '#1423': https://github.com/fedify-dev/fedify/issues/1423 | ||
| '#1445': https://github.com/fedify-dev/fedify/pull/1445 | ||
| --- | ||
| - Added the `AcceptedDocumentCallback<T>` type for callbacks that receive a | ||
| fetched vocabulary target and the exact loader response accepted for it. | ||
| [[#1423], [#1445] by Jiwon Kwon] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| links: | ||
| '#1423': https://github.com/fedify-dev/fedify/issues/1423 | ||
| '#1445': https://github.com/fedify-dev/fedify/pull/1445 | ||
| --- | ||
| - Added an `onAcceptedDocument` option to generated plural dereferencing | ||
| accessors so applications can associate fetched targets with their exact | ||
| accepted loader responses. [[#1423], [#1445] by Jiwon Kwon] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| links: | ||
| '#1423': https://github.com/fedify-dev/fedify/issues/1423 | ||
| '#1445': https://github.com/fedify-dev/fedify/pull/1445 | ||
| --- | ||
| - Added `onAcceptedDocument` to plural dereferencing accessors. The | ||
| synchronous callback receives each newly fetched, accepted target and its | ||
| exact `RemoteDocument` before caching or yielding. Embedded targets and | ||
| cache hits do not trigger it. The `AcceptedDocumentCallback<T>` type is | ||
| also exported. [[#1423], [#1445] by Jiwon Kwon] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the custom-accessor action in the release note.
Custom
getReplyTargets()implementations must forwardonAcceptedDocumentor report accepted responses themselves to preserve source defaults. Add that guidance so users can identify the required change when they upgrade.As per coding guidelines, each fragment must describe “what users should do differently.”
markdownlint-cli2 (0.24.0)
[warning] 6-6: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
Source: Coding guidelines