Repository navigation
Description
Why
RFC 9421 supports several signature algorithms, and packages/fedify/src/sig/http.ts already maps verification identifiers such as rsa-pss-sha512, ecdsa-p256-sha256, ecdsa-p384-sha384, and ed25519. Signing is narrower: signRequestRfc9421() currently rejects anything except RSASSA-PKCS1-v1_5 and always emits rsa-v1_5-sha256.
That means Fedify can verify more peer signatures than it can produce. It also makes Accept-Signature challenges with compatible non-RSA algorithms impossible to satisfy with a matching local key.
Current code
signRequestRfc9421() and the draft-cavage path are in packages/fedify/src/sig/http.ts. Key validation and generation live in packages/fedify/src/sig/key.ts. Existing signature tests are in packages/fedify/src/sig/http.test.ts and packages/fedify/src/sig/key.test.ts.
Scope
Add RFC 9421 signing support for at least one non-RSASSA-PKCS1-v1_5 algorithm already understood by the verifier. Ed25519 is probably the best first target because generateCryptoKeyPair() already supports it.
The implementation should:
- choose the correct RFC 9421
algvalue from the private key; - call
crypto.subtle.sign()with the right WebCrypto algorithm parameters; - keep draft-cavage signing behavior unchanged unless there is a clear compatibility reason;
- update
Accept-Signaturefulfillment so a compatible local key can satisfy a matching challenge; - keep metrics attributes bounded to known algorithm names.
Non-goals
Do not remove RSA PKCS#1 as the default. Do not add algorithms that cannot be generated or imported consistently across Deno, Node.js, and Bun. Do not weaken existing key validation for ActivityPub compatibility.
Suggested checks
Add signing and verification round-trip tests in packages/fedify/src/sig/http.test.ts. Add key tests in packages/fedify/src/sig/key.test.ts if the accepted key set changes. Please verify at least Deno and one Node/Bun path if runtime support differs.
Metadata
Metadata
Assignees
Labels
Type
Fields
Priority
Effort
Activity
notJoon commentedon Jul 6, 2026
I understand this issue is reserved for OSSCA mentees, but if there are no volunteers, would it be okay for you to assign it to me?
dahlia commentedon Jul 6, 2026
@notJoon Sure!
Jae-Hyuk-Jang commentedon Sep 4, 2026
@dahlia This issue has been open for a while without an assignee. If it's still available, I'd like to take it on — could you assign it to me?
dahlia commentedon Sep 14, 2026
@notJoon, when you asked back in July, I said I'd assign this to you, and then I forgot to actually do it. That's on me. @Jae-Hyuk-Jang has since asked to take it on.
@notJoon, are you still interested? If I don't hear back by September 21, I'll assign it to @Jae-Hyuk-Jang. @Jae-Hyuk-Jang, thanks for the offer and for your patience while I check.
Jae-Hyuk-Jang commentedon Oct 1, 2026
@dahlia Could I be assigned this issue now?
dahlia commentedon Oct 1, 2026
@Jae-Hyuk-Jang Assigned, thanks!
github-actions commentedon Oct 16, 2026
@Jae-Hyuk-Jang This issue has been assigned for over two weeks without updates. Please provide a status update, or unassign yourself if you're unable to continue working on it.
Jae-Hyuk-Jang commentedon Oct 16, 2026
Sorry for the delay. I'm working on it right now and will update it soon.
github-actions commentedon Oct 31, 2026
@Jae-Hyuk-Jang This issue has been assigned for over two weeks without updates. Please provide a status update, or unassign yourself if you're unable to continue working on it.
Jae-Hyuk-Jang commentedon Oct 31, 2026
Sorry for the delay. I'm working on it right now and will update it soon.
Sign RFC 9421 requests with Ed25519 keys
Answer ed25519 Accept-Signature challenges
Document Ed25519 HTTP Message Signatures
Sign RFC 9421 requests with Ed25519 keys
Answer ed25519 Accept-Signature challenges
Document Ed25519 HTTP Message Signatures
github-actions commentedon Nov 15, 2026
@Jae-Hyuk-Jang This issue has been assigned for over two weeks without updates. Please provide a status update, or unassign yourself if you're unable to continue working on it.
Jae-Hyuk-Jang commentedon Nov 15, 2026
Status update: I opened #1438 for this issue on November 13, and it is now in review.