Skip to content

refactor: remove unused re-exports from pseudo-selectors - #1908

Merged
fb55 merged 1 commit into
masterfrom
chore/knip-cleanup
Oct 9, 2026
Merged

fb55 merged 1 commit into
masterfrom
chore/knip-cleanup

Conversation

@fb55

@fb55 fb55 commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Found with knip.

src/pseudo-selectors/index.ts re-exported aliases, filters and pseudos,
but nothing imports them from there and the package entry point does
not expose them. The modules themselves are unchanged and still used by
compilePseudoSelector.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • API Changes
    • The pseudo-selectors entry point no longer re-exports aliases, filters, or pseudos.

Found with knip.

src/pseudo-selectors/index.ts re-exported aliases, filters and pseudos,
but nothing imports them from there and the package entry point does
not expose them. The modules themselves are unchanged and still used by
compilePseudoSelector.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 9, 2026 14:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T14:04:35.911947Z 27639b8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 36701d52-861e-4f15-9bdd-a2eacacf5109

📥 Commits

Reviewing files that changed from the base of the PR and between 07f968f and 27639b8.


📒 Files selected for processing (1)
  • src/pseudo-selectors/index.ts

💤 Files with no reviewable changes (1)
  • src/pseudo-selectors/index.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.



📝 Walkthrough

Walkthrough

The pseudo-selectors index no longer re-exports aliases, filters, or pseudos.

Changes

Pseudo-selector exports

Layer / File(s) Summary
Remove module re-exports
src/pseudo-selectors/index.ts
The index no longer re-exports aliases, filters, or pseudos.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor


Merge Risk: ⚪ Minimal · up to 27639

No affected supported consumer or actionable merge risk was found. The change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing unused re-exports from pseudo-selectors.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit peeks at exports gone,
Three names hop off and scamper on.
The index keeps a tidier face,
While carrots wait in their old place.
I nibble, then inspect the trace.

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

0 open findings

What changed in this PR

Removes the barrel re-exports from the src/pseudo-selectors entrypoint, leaving only compilePseudoSelector exported from this module.

Changes:

  • Removed re-exports for aliases, filters, and pseudos from src/pseudo-selectors/index.ts.
File Description
src/​pseudo-selectors/​index.ts Drops module re-exports from the package entrypoint, impacting how consumers import pseudo-selector helpers.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; the removed re-exports have no supported callers.

Summary

Removed unused re-exports of aliases, filters, and pseudos from src/pseudo-selectors/index.ts.

  • The pseudo-selector index no longer exports its three lookup tables.

Reviews (1) · Last reviewed commit: "refactor: remove unused re-exports from ..." · Reviewed by Greptile

@fb55
fb55 merged commit 7db1b2c into master Oct 9, 2026
16 of 17 checks passed
@fb55
fb55 deleted the chore/knip-cleanup branch October 9, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants