Skip to content

build(deps-dev): bump @feedic/eslint-config from 0.4.1 to 0.5.0 - #1827

Merged
fb55 merged 15 commits into
masterfrom
dependabot/npm_and_yarn/feedic/eslint-config-0.5.0
Oct 11, 2026
Merged

fb55 merged 15 commits into
masterfrom
dependabot/npm_and_yarn/feedic/eslint-config-0.5.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 24, 2026 •

Copy link
Copy Markdown
Contributor

Upgrades @feedic/eslint-config to 0.5.0 and adapts the repository to its new rules after merging the current base branch. Applies narrow lint fixes and compatibility settings for the existing public API, custom DOM nodes and test fixtures.

Auto-merge is disabled on this PR. The workflow also excludes shared lint-config updates from future automatic merging so rule changes receive manual review.

Validation: lint, build and the existing test suite pass locally; modified automation passes actionlint. Fresh GitHub CI runs on the pushed commit.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 24, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions
github-actions Bot enabled auto-merge (squash) June 24, 2026 13:52
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/feedic/eslint-config-0.5.0 branch 3 times, most recently from e10a35e to 88fc920 Compare July 1, 2026 13:55
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/feedic/eslint-config-0.5.0 branch 2 times, most recently from 424645d to 5055444 Compare July 13, 2026 13:55
@fb55

fb55 commented Aug 31, 2026

Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps [@feedic/eslint-config](https://github.com/fb55/eslint-config) from 0.4.1 to 0.5.0.
- [Commits](fb55/eslint-config@v0.4.1...v0.5.0)

---
updated-dependencies:
- dependency-name: "@feedic/eslint-config"
  dependency-version: 0.5.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/feedic/eslint-config-0.5.0 branch from 5055444 to 3c33a0e Compare August 31, 2026 13:35
@fb55
fb55 disabled auto-merge October 9, 2026 13:00
fb55 added 2 commits October 9, 2026 14:02
…ot/npm_and_yarn/feedic/eslint-config-0.5.0

# Conflicts:
#	package-lock.json
#	package.json
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 32c172dd-ae25-4706-9d64-139844b74b9a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fb55

fb55 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

@coderabbitai review

@fb55
fb55 requested a balanced review from Copilot October 9, 2026 19:00
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review skipped.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Registry lookups accept inherited properties, and the upgraded lint toolchain conflicts with the repository’s declared Node 20 development path.

2 open findings
What changed in this PR

Upgrades the shared ESLint configuration and adapts source, tests, and automation to the new rules.

Changes:

  • Updates ESLint dependencies and lockfile.
  • Applies lint-driven naming, documentation, and compatibility changes.
  • Excludes shared lint-config updates from Dependabot auto-merge.
File Description
.github/​workflows/​dependabot-automerge.yml Requires manual review for lint-config updates.
eslint.config.mjs Disables an incompatible DOM rule for fixtures.
package.json Upgrades the shared ESLint config.
package-lock.json Updates resolved lint dependencies.
src/​compile.ts Modernizes a documentation URL.
src/​general.ts Renames boolean matcher functions.
src/​helpers/​cache.ts Renames boolean matcher parameters and results.
src/​helpers/​options.ts Documents the options parameter.
src/​helpers/​selectors.ts Adapts selector checks and lint compatibility.
src/​index.ts Renames the equality predicate and preserves public API naming.
src/​pseudo-selectors/​filters.ts Renames boolean predicates.
src/​pseudo-selectors/​index.ts Replaces pseudo-registry membership checks.
src/​pseudo-selectors/​pseudos.ts Renames whitespace and predicate identifiers.
src/​pseudo-selectors/​subselects.ts Renames the cache-control boolean.
test/​api.ts Simplifies repeated-string construction.
test/​nwmatcher.ts Updates documentation URLs.
test/​sizzle.ts Applies lint-compatible fixture updates.
test/​tools/​helper.ts Reworks body extraction assignment.
test/​tools/​sizzle-testinit.ts Documents a fixture-reset lint exception.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
Comment thread src/pseudo-selectors/index.ts Outdated
@fb55
fb55 requested a balanced review from Copilot October 9, 2026 23:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The inherited pseudo-name regression remains reachable through an empty custom pseudos object.

1 open finding
1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Guard custom pseudo lookup against inherited properties

test/​api.ts:140

These cases only cover the built-in pseudo tables. The public custom-pseudo path still reads options.pseudos?.[name], so CSSselect.compile(":constructor", { pseudos: {} }) resolves the inherited Object.prototype.constructor function and does not throw. Please add this option shape to the regression cases and guard the custom pseudo lookup with an own-property check as well.

🧠 Review effort: Balanced

@fb55
fb55 requested a balanced review from Copilot October 9, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency upgrade, compatibility changes, regression tests, and CI baseline are internally consistent with no unresolved correctness issues.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@fb55
fb55 merged commit 94edb4b into master Oct 11, 2026
10 checks passed
@fb55
fb55 deleted the dependabot/npm_and_yarn/feedic/eslint-config-0.5.0 branch October 11, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants