You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build(deps-dev): bump @feedic/eslint-config from 0.4.1 to 0.5.0 - #1827
Upgrades @feedic/eslint-config to 0.5.0 and adapts the repository to its new rules after merging the current base branch. Applies narrow lint fixes and compatibility settings for the existing public API, custom DOM nodes and test fixtures.
Auto-merge is disabled on this PR. The workflow also excludes shared lint-config updates from future automatic merging so rule changes receive manual review.
Validation: lint, build and the existing test suite pass locally; modified automation passes actionlint. Fresh GitHub CI runs on the pushed commit.
Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Guard custom pseudo lookup against inherited properties
test/api.ts:140
These cases only cover the built-in pseudo tables. The public custom-pseudo path still reads options.pseudos?.[name], so CSSselect.compile(":constructor", { pseudos: {} }) resolves the inherited Object.prototype.constructor function and does not throw. Please add this option shape to the regression cases and guard the custom pseudo lookup with an own-property check as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filejavascriptPull requests that update Javascript code
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades @feedic/eslint-config to 0.5.0 and adapts the repository to its new rules after merging the current base branch. Applies narrow lint fixes and compatibility settings for the existing public API, custom DOM nodes and test fixtures.
Auto-merge is disabled on this PR. The workflow also excludes shared lint-config updates from future automatic merging so rule changes receive manual review.
Validation: lint, build and the existing test suite pass locally; modified automation passes actionlint. Fresh GitHub CI runs on the pushed commit.