connmgr: add prometheus metrics - #48394
Merged
Merged
Conversation
clintjedwards
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Prometheus metrics to connmgr entirely in Rust and using the
prometheuscrate. It implements a Prometheus server using thehttp1module, and adds one metric to start out with (total_requests). Metrics are declared per-component, in this case withinconnmgr::metrics, whereas the Prometheus server itself lives incore. This way each component can reuse the server but register distinct metrics.Notably, these metrics are not implemented using the
StatsManagerC++ class which supports Prometheus. It also doesn't implement cross-component aggregation likeStatsManagerdoes. This is intentional and part of a plan of phasing out the use ofStatsManagerfor operational metrics, in favor of having each component serve their own metrics without any internal aggregation. After this lands, we can consider porting other components to use it as well, and removing Prometheus support fromStatsManager.