Vulkan: fixes driver name concatenation on multi-GPU systems - #2620
Merged
Merged
Conversation
applyDriverName appended to the result buffer without clearing it. When a later device reported a higher API version, its driver name was appended to the name of the earlier device instead of replacing it, as the comment in detectVulkan intends.
fastfetch-cli#2616 was opened after 2.69.0 had been released, but its entry was written under 2.69.0 Bugfixes, so the changelog listed the fix as part of 2.69.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyDriverNameappends to the result buffer without clearing it. When a later device reports a higher API version, its driver name is appended to the name of the earlier device instead of replacing it, as the comment indetectVulkanintends. Details in #2619.Related issue (required for new logos for new distros)
Closes #2619
Changes
applyDriverName.--format json#2615 entry from 2.69.0 to Unreleased: I opened Brightness (Linux): fixes random built-in flag and stdout leak in DDC/CI detection #2616 after 2.69.0 was already out but wrote the entry under 2.69.0, so the changelog currently lists that fix as part of 2.69.0. Happy to drop that commit if you'd rather handle it yourself.Screenshots
Not a visual change. Same machine (AMD Raphael iGPU with radv + NVIDIA RTX 5060 with the proprietary driver):
Checklist
Built on
dev@ 9801d89.ctestpasses (19/19) with-DBUILD_TESTS=ON, andclang-format-diffreports nothing for the changed lines.