馃懛 Fix mypy and ty pre-commit hooks not using config from backend/pyproject.toml - #2475
Open
YuriiMotov wants to merge 2 commits into
Open
馃懛 Fix mypy and ty pre-commit hooks not using config from backend/pyproject.toml#2475YuriiMotov wants to merge 2 commits into
backend/pyproject.toml#2475YuriiMotov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I recently discovered that mypy running on pre-commit doesn't work the same way as if we run it with
bash scripts/lint.sh.The reason is that prek runs it from the root directory and it uses the
pyproject.tomlof the root project, but config is inbackend/pyproject.toml.To fix this we need to specify the config file to use in the command.
The same is true for ty. We don't see it currently as the current config is equal to default settings.
To check, modify the mypy config (for example, add
disallow_any_explicit = trueto[tool.mypy]) and then run prek from root directory:prek run local-mypy --all-files.This will pass on master (because config is not used) and show lots of
explicit-anyon this branch (this proves that mypy now uses config frombackend/pyproject.toml).Same with ty: add
[tool.ty.environment] python-version = "3.9", runprek run local-ty --all-files, see no errors onmasterand 6 errors on this branch.AI Disclaimer
Used Claude Code (Fable 5) to investigate and apply the fix. Checked manually
Checklist