Skip to content

style: fix ruff format on postgres insert grammar test#132

Closed
bedus-creation wants to merge 1 commit into
mainfrom
fix/ruff-format-postgres-grammar
Closed

style: fix ruff format on postgres insert grammar test#132
bedus-creation wants to merge 1 commit into
mainfrom
fix/ruff-format-postgres-grammar

Conversation

@bedus-creation

Copy link
Copy Markdown
Contributor

Summary

main is currently failing CI on uv run ruff format --check . because of tests/masoniteorm/postgres/grammar/test_postgres_insert_grammar.py (introduced in 7168863, PR #130). This applies ruff format to that single file.

No logic change — formatting only.

Verification

uv run ruff format --check .
510 files already formatted

This unblocks CI on main and on dependent open PRs (e.g. #131).

Formatting fix for the test added in 7168863; main was failing
'ruff format --check .'.
@bedus-creation

Copy link
Copy Markdown
Contributor Author

Code review: APPROVED — formatting-only hotfix verified (formal GitHub approval blocked by shared author identity).

  1. ✅ Diff touches ONLY tests/masoniteorm/postgres/grammar/test_postgres_insert_grammar.py (1 file, +1/-2).
  2. ✅ No logic/import/behaviour change — the two-line implicitly-concatenated string literal is collapsed into one equivalent single-line literal; the resulting SQL string value is byte-identical (INSERT INTO "users" ("name", "email") VALUES ('Joe', 'joe@example.com'), ('Bob', 'bob@example.com')).
  3. uv run ruff format --check . → 510 files already formatted, 0 violations.

Bonus: the 3 grammar tests in the file still pass. Clears the CI block on main — ready to merge.

@bedus-creation

Copy link
Copy Markdown
Contributor Author

Superseded — folded the formatting fix directly into #131 (now updated to latest main), so #131 is self-sufficient and green. Closing this to avoid a duplicate PR.

@bedus-creation bedus-creation deleted the fix/ruff-format-postgres-grammar branch June 19, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant