Skip to content

Dev - #312

Merged
fangfufu merged 2 commits into
masterfrom
dev
Oct 9, 2026
Merged

Dev#312
fangfufu merged 2 commits into
masterfrom
dev

Conversation

@fangfufu

@fangfufu fangfufu commented Oct 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation
    • Updated build instructions to use a consistent build directory across platforms.
    • Clarified commands for running unit and integration tests, including test suites and verbose output.
  • Chores
    • Build and code-analysis workflows now use the same build directory and retain Meson logs from macOS and Ubuntu builds.
    • Updated release version metadata to report version 1.3.3.

@fangfufu
build: define VERSION in config.h instead of Meson macro injection
23f9e85 
Meson previously injected -DVERSION at compile time, leaving the macro
undefined for LSPs and tools that don't use compile_commands.json.
Define it in src/config.h (included by every use-site) and remove the
version from project() and c_args.

Also fix release-please extra-files: replace stale USAGE.md path with
docs/usage.md and add src/config.h so both are bumped on release.
@fangfufu
build: consolidate on a single build/ Meson directory
1c774ee 
Use build/ everywhere instead of builddir/: docs, README, CI workflows,
the clang-tidy pre-commit hook, and .gitignore. This also matches the
directory clangd auto-discovers for compile_commands.json.
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0f4adba4-4501-4e24-9c16-6b5a7abf7c79
📥 Commits

Reviewing files that changed from the base of the PR and between 2299b8a and 1c774ee.

📒 Files selected for processing (10)
  • .github/workflows/build.yml
  • .github/workflows/codeql.yml
  • .github/workflows/pre-commit.yml
  • .gitignore
  • .pre-commit-config.yaml
  • README.md
  • docs/development.md
  • meson.build
  • release-please-config.json
  • src/config.h
 ________________________________________________________________________
< Making the Death Star fully operational, with zero exhaust port flaws. >
 ------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fangfufu
fangfufu merged commit d120efb into master Oct 9, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fangfufu