Repository navigation
Conversation
In collect_gumbo_text, the initial buffer capacity was hardcoded to 256 bytes without checking if the incoming text chunk plus terminator exceeded 256 bytes. When anchor text was >= 256 bytes, this caused an out-of-bounds heap write. Ensure capacity dynamically doubles until it fits needed bytes (*len + tlen + 1), check for arithmetic overflow, and add boundary unit tests covering anchor text lengths 255, 256, 257, and 1024 bytes. Fixes #308
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds overflow checks and geometric buffer growth to HTML anchor text collection. Tests cover long anchor labels, boundary text lengths, and text accumulated across nested tags. ChangesAnchor text collection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No confirmed issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 1 | ❓ 1❌ Failed checks (1 warning, 1 inconclusive)✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Summary by CodeRabbit