chore: add destination to incoming federation responses metrics#272
Open
jason-famedly wants to merge 1 commit into
Open
chore: add destination to incoming federation responses metrics#272jason-famedly wants to merge 1 commit into
destination to incoming federation responses metrics#272jason-famedly wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a destination label to the synapse_http_matrixfederationclient_responses Prometheus counter so incoming federation response metrics can be broken down by the remote server being contacted.
Changes:
- Extend
synapse_http_matrixfederationclient_responsescounter label set to includedestination. - Populate the new
destinationlabel fromMatrixFederationRequest.destinationwhen incrementing the counter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 80.42% 80.42% -0.01%
==========================================
Files 502 502
Lines 72430 72430
Branches 10917 10917
==========================================
- Hits 58254 58250 -4
- Misses 10896 10900 +4
Partials 3280 3280
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
jason-famedly
changed the title
destination to incoming federation responses metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYN-61
Add a
destinationlabel to the incoming responses for federation requests, undersynapse_http_matrixfederationclient_responses.