Stop using blind exceptions - #98
Open
itsoyou wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ff296f5. Configure here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 76.35% 76.76% +0.40%
==========================================
Files 9 9
Lines 791 792 +1
Branches 146 146
==========================================
+ Hits 604 608 +4
+ Misses 131 128 -3
Partials 56 56
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
itsoyou
force-pushed
the
syk/stop-using-blind-exceptions
branch
from
August 27, 2026 10:15
56d6d60 to
32f937c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SYN-96
config.pyis out of scope because of its ongoing refactoring from other pr.Note
Low Risk
Behavioral change is mainly which exceptions propagate during login; auth still fails closed by returning None, with narrower catch scopes reducing risk of hiding unexpected errors.
Overview
Replaces generic
Exceptionraises andexcept Exceptionblocks with typed errors so configuration and OAuth login failures are easier to reason about and do not swallow unrelated bugs.Claims validation introduces
InvalidClaimsValidatorError(ValueError) for bad validator DSL definitions, andClaimsMismatchErrorwhen JWT vs introspection claim sources disagree (viaall_list_elems_are_equal_return_the_elem).token_authenticatorOAuth flow now catches onlyClaimsMismatchErrorandSynapseErrorfor those paths instead of any exception.HttpAuth parsing raises
ValueErrorfor unknown types and malformed input;parse_authlogs and re-raises onlyValidationError,KeyError,IndexError, andValueError. Tests expectValueErrorfor bad auth config.config.pyis intentionally unchanged (other PR).Reviewed by Cursor Bugbot for commit 32f937c. Bugbot is set up for automated code reviews on this repo. Configure here.