Skip to content

Release: fix tagging failure, catch up missed releases - #20

Merged
fadeltd merged 1 commit into
mainfrom
fix/release-pipefail
Oct 29, 2026
Merged

fadeltd merged 1 commit into
mainfrom
fix/release-pipefail

Conversation

@fadeltd

@fadeltd fadeltd commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Added

  • CI check that fails a PR whose changelog entries would land in an already released section
  • scripts/release-notes.ts prints one version's notes

Changed

  • Tagging runs on every merge and catches up release commits that were never tagged, released or deployed

Fixed

  • Release no longer fails with exit 141 (SIGPIPE) after pushing the release commit
  • The JSON filter changelog entry moved back to [Unreleased], so it releases

…og placement

The tagging step added in #16 found the release commit with `git log | awk '{ print; exit }'`. awk stopped at the first line, git log died of SIGPIPE, and under pipefail the exit 141 failed the step right after the release commit was pushed. #17, #18 and #19 each got a release commit (v0.8.0 + core-v0.2.0, v0.9.0, core-v0.3.0) but no tag, no GitHub release and no deploy; the site is still on v0.7.0. The "Bypassed rule violations" line above the failure is the usual notice that the Actions bot went around the PR rule on main, and every earlier release printed it too.

Tagging is now its own step that runs on every merge. It walks back from main to the newest release commit whose tags and GitHub releases all exist, then, oldest first, tags each later release commit, creates its GitHub release from the changelog as it stood at that commit, and deploys the newest site tag. No pipe in it stops reading early, and the stray-tag check is kept. Merging this PR tags v0.8.0, core-v0.2.0, v0.9.0 and core-v0.3.0, and cuts and deploys v0.10.0.

The A-17 entry moves from [0.9.0] back to [Unreleased]. The branch was cut before Release v0.9.0 landed, and the squash merge kept the new line beside the pinned-tools entry, which by then sat under 0.9.0, so #19 released nothing. A new CI step on pull requests, scripts/check-changelog.ts, fails when a merge would put any of the PR's [Unreleased] lines into an already released section; replayed on #19's merge it fails, on #18's it passes. Corrections to past release notes are not flagged.

Also: the CI tarball check uses a here-string instead of `echo | grep -q`, release.ts no longer emits the notes output nothing reads, and CLAUDE.md and CONTRIBUTING.md describe the catch-up, the rebase rule and the two workflow pitfalls.
@fadeltd fadeltd self-assigned this Oct 29, 2026
@fadeltd
fadeltd merged commit e3d0310 into main Oct 29, 2026
1 check passed
@fadeltd
fadeltd deleted the fix/release-pipefail branch October 29, 2026 08:50
@fadeltd fadeltd changed the title Release: tag without SIGPIPE, catch up missed releases, check changelog placement Release: fix tagging failure, catch up missed releases Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant