fix: validate audio paths before metadata reads - #70
Open
KevinTran3011 wants to merge 1 commit into
Open
Conversation
Author
|
Research note: the CodeQL custom query identified a validation-order issue (CWE-22-style path confinement). multi_stem_masking called soundfile.info() before load_audio() applied validate_input_path(), so PHANTOM_AUDIO_DIR confinement could be bypassed for metadata reads. This patch validates every path first and uses the validated paths for both metadata and decoding. Please review the policy when PHANTOM_AUDIO_DIR is unset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief description of what this PR does and why.
Changes
Test Plan
How was this tested?
Checklist
uv run pytest tests/ -x -q)uv tool run ruff check src/ tests/)uv tool run ruff format --check src/ tests/)