Update CMake config to also use find module for c-ares#623
Open
mszabo-wikia wants to merge 1 commit into
Open
Conversation
D93368374 reverted D81248145 to use the find module for c-ares vendored in fbcode_builder instead of c-ares' own CMake config which may be absent when building against system c-ares on older installs (e.g. Ubuntu Jammy). Do the same for proxygen's CMake config so that projects that depend on proxygen also build against system c-ares in such environments.
|
@afrind has imported this pull request. If you are a Meta employee, you can view this in D107700038. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D93368374 reverted D81248145 to use the find module for c-ares vendored in fbcode_builder instead of c-ares' own CMake config which may be absent when building against system c-ares on older installs (e.g. Ubuntu Jammy).
Do the same for proxygen's CMake config so that projects that depend on proxygen also build against system c-ares in such environments.