fix: memory leak in Link - #12326
Open
SimonSiefke wants to merge 1 commit into
Open
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Docusaurus
Linkcreated a new callback ref on every render. React detached the old ref withnull, but that path did not disconnect itsIntersectionObserver, so the document's observer controller retained the old callback closure.Change
Keep the callback ref stable while its inputs are unchanged, and disconnect and clear the active observer whenever the ref target changes or unmounts.
Before
When navigating between Playwright's Installation and Writing tests pages 37 times, the observer callback,
innerRef, and interaction callback each grow by 3,922 instances:After
No more matching
Linkobserver leak is detected.Test Video
test-video.webm
Additional Info