[fabiodalez-dev]

Release 1.12.0 (versionCode 26), paired with Pinakes 0.9.0 and 0.9.1.

Changes

• Same-day handover after a closure. Pinakes 0.9.0 added same_day_handover_after_closure to the loan settings: when a loan is due on a closed day, another reader can receive the book on the first open day. The Mobile API sends it in GET /staff/settings/loans, but the app's loan form skips keys it does not know. The setting was safe, because a save sends only changed fields, but it could not be seen or changed from the app. Library settings → Loans now has the web's Closures calendar section with this switch, its help text in it, en, de and fr (the server's wording), and the same order as the web page.
• Version and STATUS.md. 1.12.0 also ships [codex] Align reader and staff loans with the server calendar #58, already on main: loans show effective_due_at and follow the server's is_overdue.

Older servers

A server that does not send the key shows no switch and sends nothing about it.

Tests

Staff090LibraryFormsTest.theSameDayHandoverSwitchFollowsTheClosuresCalendarAndIsSentWhenChanged uses a 0.9.1 response (s090_library_loans_staff_091.json), staff role. It checks:

• the field is a switch in the closures section, between app_timezone and pickup_expiry_days;
• staff can edit it;
• the body sent is only the changed key.

The same test checks that the rc.2 response yields no switch and no body. Staff090LibraryFormsTest (26) and Staff090LibraryUiTest (5) pass locally.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8731a29a-fa3c-4858-85f1-acd1942a5321

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[pullfrog]

✅ No new issues found.

Reviewed changes

I reviewed the 1.12.0 release commit. It adds the same-day handover switch to Library settings → Loans and bumps the version.

• New CLOSURES loan section: same_day_handover_after_closure is a BOOL field placed between app_timezone and pickup_expiry_days. LoansTab iterates LoanSection.entries and skips empty sections, so the Closures calendar heading only appears when the server sends the key.
• Behaviour on older servers: LoansForm.fields() filters on loans.settings, so a server that doesn't send the key shows nothing and puts nothing about it in the body. When the key is present but not in editable_fields, the existing read-only On/Off path handles it.
• Strings: label, help and section title are added to en/it/de/fr. The four files still have the same keys, and the new copy has no em dashes.
• Tests: the new 0.9.1 staff fixture and test check the field's kind, section, order, editability and the single-key patch body. The test also checks that the rc.2 fixture produces no field and a null body.
• Release metadata: versionCode 26 / versionName 1.12.0, and a new STATUS.md section that also covers #58.

  ^{｜ View workflow run ｜ Using claude-opus-5-5 ｜ 𝕏}