Repository navigation
Preserve original mapping keys when deriving CSV columns - #622
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 64 64
Lines 2430 2431 +1
=======================================
+ Hits 2394 2395 +1
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fabiocaccamo
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When no CSV columns are supplied,
to_csv()converts the first row's keys to strings before looking up row values. Integer keys therefore produce empty cells:{1: "first", 2: "second"}is exported as1,2\n,\n.Keep the original keys for lookup and sort them by their string representation. Inferred headers keep their string labels, including None, while explicit columns keep their existing writer behavior. Regression cases cover integer keys, mixed string/integer keys, None keys, explicit None columns, and output without a header row.
Related issue
Found while checking serializer round trips; no existing issue found for this case.
Checklist before requesting a review
Validation on Python 3.14: four regression cases fail on the original source; related tests pass (18 tests); the full suite passes (928 tests, 1 skipped); all pre-commit hooks including Ruff/mypy pass; wheel and sdist builds pass.