Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion benedict/serializers/csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ def decode(self, s: str, **kwargs: Any) -> list[dict[str, Any]]:
kwargs.setdefault("quoting", csv.QUOTE_ALL)
columns = kwargs.pop("columns", None)
columns_row = kwargs.pop("columns_row", True)
f = StringIO(s)
# 2026-10-11: Let csv handle record endings and preserve quoted newlines.
f = StringIO(s, newline="")
r = csv.reader(f, **kwargs)
ln = 0
data = []
Expand Down
13 changes: 13 additions & 0 deletions tests/serializers/test_csv_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@ def test_decode_csv(self) -> None:
# TODO
pass

# 2026-10-11: CSV readers accept CR, LF and CRLF without rewriting quoted data.
def test_decode_csv_newlines(self) -> None:
from benedict.serializers import CSVSerializer

serializer = CSVSerializer()
for newline in ("\r", "\n", "\r\n"):
with self.subTest(newline=newline):
text = f'name,note{newline}Alice,"first\r\nsecond"{newline}'
self.assertEqual(
serializer.decode(text),
[{"name": "Alice", "note": "first\r\nsecond"}],
)

def test_encode_csv(self) -> None:
# TODO
pass
Loading