Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benedict/core/keylists.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _get_keylist_for_value(
) -> list[list[Any]]:
if type_util.is_dict(value):
return _get_keylist_for_dict(value, parent_keys, indexes)
elif type_util.is_list(value) and indexes:
elif type_util.is_list_or_tuple(value) and indexes:
return _get_keylist_for_list(value, parent_keys, indexes)
return []

Expand Down
17 changes: 17 additions & 0 deletions tests/core/test_keypaths.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,3 +303,20 @@ def test_keypaths_with_nested_lists_and_indexes_included(self) -> None:
"a.b[2][0].y",
]
self.assertEqual(o, r)

def test_keypaths_with_tuple_indexes(self) -> None:
data = {"items": ({"value": 1}, (2, 3), [4])}
self.assertEqual(
_keypaths(data, indexes=True),
[
"items",
"items[0]",
"items[0].value",
"items[1]",
"items[1][0]",
"items[1][1]",
"items[2]",
"items[2][0]",
],
)
self.assertEqual(_keypaths(data, indexes=False), ["items"])
6 changes: 6 additions & 0 deletions tests/core/test_match.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import re
import unittest

from benedict import benedict
from benedict.core import match as _match


Expand Down Expand Up @@ -72,3 +73,8 @@ def test_match_with_invalid_pattern(self) -> None:
d = self._get_dict()
with self.assertRaises(ValueError):
_ = _match(d, 100) # type: ignore[arg-type]

def test_match_with_tuple_indexes(self) -> None:
data = benedict({"items": ({"value": 1}, {"value": 2})})
self.assertEqual(data["items[0].value"], 1)
self.assertEqual(data.match("items[*].value"), [1, 2])
Loading