feat: add shared keychain support for device UUIDs#45
Open
edusperoni wants to merge 1 commit into
Open
Conversation
fabiocaccamo
requested changes
Jul 15, 2026
| _uuidForDeviceShared = [NSString stringWithString:value]; | ||
| [self _setValue:_uuidForDeviceShared forKey:_uuidForDeviceSharedKey userDefaults:NO keychain:YES service:_uuidForDeviceSharedService accessGroup:_sharedAccessGroup synchronizable:NO]; | ||
|
|
||
| return _uuidForDeviceShared; |
Owner
There was a problem hiding this comment.
The method validates value before checking if a shared UUID already exists.
This conflicts with the intended behavior (“if shared UUID already exists, return it unchanged”).
If callers run migration unconditionally and pass nil/invalid input while a shared UUID already exists, this will throw unexpectedly.
Should check existingSharedDeviceUUID first, and only validate value when creating a new shared UUID.
Author
There was a problem hiding this comment.
Thanks, I have a few other adjustments that I made. I'll update the PR. One thing I noticed is that we don't restrict the key to "this device only" so backups and restores on a different device duplicate the id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.