Improves workflow:create command#3943
Draft
jonsamp wants to merge 5 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
+ Coverage 59.24% 59.42% +0.19%
==========================================
Files 935 936 +1
Lines 41061 41020 -41
Branches 8650 8637 -13
==========================================
+ Hits 24323 24374 +51
+ Misses 16644 16552 -92
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When running
eas workflow:create, the results are not valid and they don't always work. There's more notes in the Linear task. This PR:--template build|update|deploy|customflag to select a template non-interactively.eas workflow:create <name>without--templatenow creates a minimal placeholder workflow(
name/on/jobsscaffold with doc links) instead of entering the template flow.as
eas init, letting the user pick the owning account (including organizations) instead ofsilently defaulting to the personal account. The init logic moved from
commands/project/init.tsto
src/project/projectInitialization.tsso both commands share it.developmentand
development-ios-simulatorbuild profiles ineas.jsonwhen missing (replacing the previousprofile-detection prompts), ensures
android.package/ios.bundleIdentifierare defined formanaged projects, and installs
expo-dev-clientif it isn't already a dependency.build.yml,update.yml,deploy.yml,custom.yml); namecollisions are resolved with a numeric suffix instead of re-prompting.
numbered "Next steps" list with
[Action required]items and copy-pasteable commands.howToRunWorkflow.Examples
Build template
.eas/workflows/build.ymlNext steps output
Update template
.eas/workflows/update.ymlNext steps output
Deploy template
.eas/workflows/deploy.ymlNext steps output
Custom template
.eas/workflows/custom.ymlNext steps output
Placeholder (file name without --template)
.eas/workflows/my-workflow.ymlNext steps output
Test plan
eas workflow:createin a test project: with--templatefor each template, with abare file name (placeholder path), interactively with no args, and in an unlinked project to
verify the account-selection flow.