[eas-cli] Show accurate build overage count in pre-build usage warning#3932
Open
sarahlane8 wants to merge 1 commit into
Open
[eas-cli] Show accurate build overage count in pre-build usage warning#3932sarahlane8 wants to merge 1 commit into
sarahlane8 wants to merge 1 commit into
Conversation
The overage count shown to paid users ("N builds beyond your included
credits") summed the value of every overageMetrics row, including rows
without build metadata (e.g. rollup/summary rows), which could inflate the
number. Filter to genuine per-worker build overage rows (those carrying
billingResourceClass + platform metadata) before summing.
Fetch that metadata on overageMetrics in the warning query so the rows can
be distinguished.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3932 +/- ##
==========================================
+ Coverage 59.18% 59.18% +0.01%
==========================================
Files 935 935
Lines 41075 41077 +2
Branches 8648 8649 +1
==========================================
+ Hits 24306 24308 +2
Misses 16674 16674
Partials 95 95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overage count shown to paid users ("N builds beyond your included credits") summed the value of every overageMetrics row, including rows without build metadata (e.g. rollup/summary rows), which could inflate the number. Filter to genuine per-worker build overage rows (those carrying billingResourceClass + platform metadata) before summing.
Fetch that metadata on overageMetrics in the warning query so the rows can be distinguished.