Skip to content

[eas-cli] Validate custom actions in workflow files#3931

Draft
sswrk wants to merge 1 commit into
szymonswierk/eng-22387-build-tools-load-custom-action-catalog-at-build-timefrom
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
Draft

[eas-cli] Validate custom actions in workflow files#3931
sswrk wants to merge 1 commit into
szymonswierk/eng-22387-build-tools-load-custom-action-catalog-at-build-timefrom
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files

Conversation

@sswrk

@sswrk sswrk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@linear-code

linear-code Bot commented Jul 1, 2026

Copy link
Copy Markdown

ENG-22387

sswrk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files branch from 737a707 to a01a405 Compare July 1, 2026 16:50
@sswrk sswrk force-pushed the szymonswierk/eng-22387-build-tools-load-custom-action-catalog-at-build-time branch from 32e1305 to d95f9f7 Compare July 2, 2026 16:56
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files branch from a01a405 to 23c7c61 Compare July 2, 2026 16:56
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.57%. Comparing base (d95f9f7) to head (23c7c61).

Files with missing lines Patch % Lines
...es/eas-cli/src/commandUtils/workflow/validation.ts 33.34% 2 Missing ⚠️
...kages/eas-cli/src/commandUtils/workflow/actions.ts 96.30% 1 Missing ⚠️
Additional details and impacted files
@@                                               Coverage Diff                                               @@
##           szymonswierk/eng-22387-build-tools-load-custom-action-catalog-at-build-time    #3931      +/-   ##
===============================================================================================================
+ Coverage                                                                        59.55%   59.57%   +0.03%     
===============================================================================================================
  Files                                                                              940      941       +1     
  Lines                                                                            41415    41445      +30     
  Branches                                                                          8743     8745       +2     
===============================================================================================================
+ Hits                                                                             24660    24687      +27     
- Misses                                                                           16661    16664       +3     
  Partials                                                                            94       94              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant