[build-tools] Add npm cache fallback to install_node_modules step#3924
Open
AbbanMustafa wants to merge 5 commits into
Open
[build-tools] Add npm cache fallback to install_node_modules step#3924AbbanMustafa wants to merge 5 commits into
AbbanMustafa wants to merge 5 commits into
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## npm-cache-registry-scoping #3924 +/- ##
==============================================================
+ Coverage 59.17% 59.21% +0.04%
==============================================================
Files 935 935
Lines 41070 41069 -1
Branches 8646 8646
==============================================================
+ Hits 24300 24315 +15
+ Misses 16675 16659 -16
Partials 95 95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b3c77aa to
7861230
Compare
7861230 to
9a53e4f
Compare
ae7e235 to
8597524
Compare
9a53e4f to
a467670
Compare
a467670 to
abb39a9
Compare
abb39a9 to
0f2823f
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The npm cache install fallback only covered the managed prebuild install (prebuildAsync). Workflow and generic jobs install dependencies through the eas/install_node_modules step, which called installDependenciesAsync directly and had no fallback.
How
Test Plan
installNodeModules.test.tsverifies the step installs through the cache registry on the first attempt and retries without it (dropping NPM_CONFIG_REGISTRY) when the cache install fails, and does not retry when the npm cache is not enabled.