[eas-cli] Decouple username from account name#3922
Open
byronkarlen wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3922 +/- ##
==========================================
+ Coverage 59.18% 59.21% +0.03%
==========================================
Files 935 935
Lines 41075 41090 +15
Branches 8648 8649 +1
==========================================
+ Hits 24306 24327 +21
+ Misses 16674 16669 -5
+ Partials 95 94 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
byronkarlen
force-pushed
the
byron/decouple-username-from-accountname
branch
from
005fd6f to
605567a
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas-cli shouldn't assume that a user's primary account name always has the same name as the user's username. This is currently true, but may not be in the future.
How
Had claude identify places where we make this assumption and then fixed these callsites. Added an
actor.getPersonalAccount()helper. We should use uuids and the fkey relationships provided by our data model instead of relying on unstable names wherever possible.Test Plan
tsc, and run updated unit tests. Will revisit and test thoroughly again if we decide we want to break this assumption.