[build-tools] Reset Gradle oom score before launch#3898
Merged
Conversation
sjchmiela
force-pushed
the
stanley/gradle-launch-exec
branch
from
7352b4f to
0d70011
Compare
sjchmiela
force-pushed
the
stanley/gradle-oom-score-reset
branch
from
66cbf1b to
6664fc5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
==========================================
+ Coverage 59.21% 59.25% +0.04%
==========================================
Files 935 935
Lines 41093 41066 -27
Branches 8651 8652 +1
==========================================
Hits 24329 24329
+ Misses 16670 16643 -27
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sjchmiela
force-pushed
the
stanley/gradle-launch-exec
branch
from
0d70011 to
f15ecd7
Compare
sjchmiela
force-pushed
the
stanley/gradle-oom-score-reset
branch
from
6664fc5 to
71bce04
Compare
sjchmiela
force-pushed
the
stanley/gradle-oom-score-reset
branch
from
71bce04 to
fcb02d1
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
sjchmiela
changed the title
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
szdziedzic
approved these changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gradle launch wrappers in @expo/build-tools to reset oom_score_adj immediately (at the shell level) before exec’ing ./gradlew, preventing Gradle from inheriting the worker service’s protected OOM score.
Changes:
- Replace the delayed descendant PID scan/override with a pre-launch
/proc/$$/oom_score_adjreset in the Gradle wrapper. - Simplify Gradle execution to a single awaited
spawn(...)and remove the old timeout-based process traversal logic. - Introduce a shared pattern (
getGradleShellCommand) for constructing the Gradle bash wrapper command.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/build-tools/src/steps/utils/android/gradle.ts | Switch step-based Gradle execution to a shell wrapper that resets oom_score_adj before exec ./gradlew. |
| packages/build-tools/src/android/gradle.ts | Apply the same pre-launch OOM score reset approach for the main Android build Gradle runner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+67
| const oomScoreAdjPrefix = | ||
| oomScoreAdj === undefined ? '' : `echo ${oomScoreAdj} > /proc/$$/oom_score_adj || true; `; | ||
| return `${oomScoreAdjPrefix}exec ./gradlew ${gradleCommand} --profile ${verboseFlag}`; |
Comment on lines
+74
to
+76
| const oomScoreAdjPrefix = | ||
| oomScoreAdj === undefined ? '' : `echo ${oomScoreAdj} > /proc/$$/oom_score_adj || true; `; | ||
| return `${oomScoreAdjPrefix}exec ./gradlew ${gradleCommand} --profile ${verboseFlag}`; |
Comment on lines
+65
to
77
| export function getGradleShellCommand({ | ||
| gradleCommand, | ||
| oomScoreAdj, | ||
| verboseFlag, | ||
| }: { | ||
| gradleCommand: string; | ||
| oomScoreAdj?: number; | ||
| verboseFlag: string; | ||
| }): string { | ||
| const oomScoreAdjPrefix = | ||
| oomScoreAdj === undefined ? '' : `echo ${oomScoreAdj} > /proc/$$/oom_score_adj || true; `; | ||
| return `${oomScoreAdjPrefix}exec ./gradlew ${gradleCommand} --profile ${verboseFlag}`; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
i know, fixing it in another pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the delayed Gradle descendant
oom_score_adjscan with an immediate shell-level reset before launching Gradle.The worker service is protected with
OOMScoreAdjust=-999, so Gradle inherits that value unless we reset it. This changes the Gradle launch wrapper to write0to/proc/$$/oom_score_adjbeforeexec ./gradlew ..., which makes Gradle and its child processes inherit the default OOM score instead of the worker's protected score.Validation
yarn --cwd packages/build-tools typecheckyarn oxfmt --check packages/build-tools/src/android/gradle.ts packages/build-tools/src/steps/utils/android/gradle.tsyarn oxlint --type-aware --import-plugin --tsconfig ./tsconfig.oxlint.json packages/build-tools/src/android/gradle.ts packages/build-tools/src/steps/utils/android/gradle.ts