Vpc integration - #880
Conversation
8b6be53 to
ba1ae42
Compare
ba1ae42 to
851fb14
Compare
f542a06 to
c132592
Compare
7ee5f27 to
ccbae2b
Compare
sauterp
left a comment
sauterp
left a comment
There was a problem hiding this comment.
I've been using these changes extensively during the past weeks. Consider it tested.
| Subnet string `cli-usage:"Subnet to create the route in (NAME|ID)"` | ||
| Destination string `cli-usage:"route destination CIDR (e.g. 10.9.0.0/24)"` | ||
| // TODO: Add a proper link to the doc here to explain what the target can be | ||
| Target string `cli-usage:"route target, as ip=<IP address> (e.g. ip=10.0.0.5)"` |
There was a problem hiding this comment.
I think we could document this in the API spec https://openapi-v2.exoscale.com/operation/operation-create-route#operation-create-route-body-application-json-target
currently it's empty.
There was a problem hiding this comment.
Yeah we also should point to community there, but we need a proper article as it'll be quite a complex parameter
| // NetworkingCmd is the root command for networking services. | ||
| var NetworkingCmd = &cobra.Command{ | ||
| Use: "networking", | ||
| Short: "Networking services management", |
There was a problem hiding this comment.
Should we add a note in the descriptions of this command(and perhaps all VPC commands), indicating that these features are still BETA?
There was a problem hiding this comment.
I don't know about this. My understanding was that we don't market VPC to be beta at all. It's either not there yet or available & we commit on it
So I think it make sense to just merge that & enable all VPC operation on october 31st. Which means that between the next release of the CLI & the MVP data customer can have a CLI that appears to support VPC but the API rejects all call
Wdyt ?
There was a problem hiding this comment.
sounds good to me. I think as long as we don't announce VPC officially, customers won't try these commands anyway.
Co-authored-by: Philipp Sauter <46172817+sauterp@users.noreply.github.com>
natalie-o-perret
left a comment
natalie-o-perret
left a comment
There was a problem hiding this comment.
✔️ Approving ahead of time (conflicts, and comments left by others still need to be resolved / addressed) 🚀
5 participants
Description
Heavily AI-assisted but manually used & tested
[ch190640]
The E2E tests are currently failing due to a bug in the orchestrator, we are fixing it at the source and I'll ensure those are green before merging
Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
The E2E tests are currently failing due to a bug in the orchestrator, we are fixing it at the source and I'll ensure those are green before merging