CONTRIBUTING: formatting and linting - #581
Merged
Merged
Conversation
kotp
requested changes
Sep 11, 2026
| ```bash | ||
| bin/configlet lint | ||
| bin/configlet fmt --update | ||
| ``` |
Member
There was a problem hiding this comment.
Before these can be ran, configlet should be fetched. Otherwise these commands will both fail, as will the one for the uuid functionality.
Address review feedback: bin/configlet does not exist until bin/fetch-configlet has downloaded it, so document that step before the lint/fmt/uuid commands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018FofXff2tkMmirA1Cr6aRT
kotp
approved these changes
Sep 11, 2026
kotp
left a comment
kotp
left a comment
Member
There was a problem hiding this comment.
One suggested change, otherwise looking good.
Comment on lines
+42
to
+44
| ```bash | ||
| bin/fetch-configlet # bin/fetch-configlet.ps1 on Windows | ||
| ``` |
Member
There was a problem hiding this comment.
Suggested change
| ```bash | |
| bin/fetch-configlet # bin/fetch-configlet.ps1 on Windows | |
| ``` | |
| ```sh | |
| bin/fetch-configlet | |
| ``` | |
| Or for Windows: | |
| ```sh | |
| bin/fetch-configlet.ps1 | |
| ``` |
Because it is more clear to copy and paste either statement, rather than having to "not select" the "no Windows" in the comment.
Member
There was a problem hiding this comment.
Well, that did not format very well... trying to fix it I think that fixed it.
keiravillekode
force-pushed
the
contributing
branch
from
September 11, 2026 10:25
870cf07 to
e585b8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.