Skip to content

Sync resistor-color #966 #997

Open
manupereiraduarte wants to merge 2 commits into
exercism:mainfrom
manupereiraduarte:sync-resistor-color
Open

Sync resistor-color #966 #997
manupereiraduarte wants to merge 2 commits into
exercism:mainfrom
manupereiraduarte:sync-resistor-color

Conversation

@manupereiraduarte
Copy link
Copy Markdown

Closes #966

  • Removed strict types comment block from test file and example solution
  • Added UUIDs and #[TestDox()] attributes to all tests
  • Added tests.toml with all test UUIDs
  • Added resistor-color to bin/auto-sync.txt
  • Added myself as contributor in config.json

Tests pass locally with the example solution.

Copilot AI review requested due to automatic review settings June 4, 2026 23:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR aligns the PHP resistor-color practice exercise with Exercism’s tooling by adding per-test metadata and enabling auto-sync for the exercise.

Changes:

  • Annotates PHPUnit tests with UUIDs and TestDox labels.
  • Adds the exercise’s .meta/tests.toml mapping for test descriptions.
  • Registers resistor-color for auto-sync and updates exercise metadata contributors.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
exercises/practice/resistor-color/ResistorColorTest.php Adds UUID docblocks and #[TestDox(...)] labels to tests.
exercises/practice/resistor-color/.meta/tests.toml Introduces generated UUID→description mapping for tests.
exercises/practice/resistor-color/.meta/example.php Removes the strict-types explanatory header comment.
exercises/practice/resistor-color/.meta/config.json Adds a contributor entry.
bin/auto-sync.txt Adds resistor-color to the auto-sync list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


declare(strict_types=1);

use PHPUnit\Framework\TestCase;
/**
* uuid: 581d68fa-f968-4be2-9f9d-880f2fb73cf7
*/
#[TestDox('Colors')]
/**
* uuid: 49eb31c5-10a8-4180-9f7f-fea632ab87ef
*/
#[TestDox('Black')]
/**
* uuid: 5f81608d-f36f-4190-8084-f45116b6f380
*/
#[TestDox('Orange')]
/**
* uuid: 0a4df94b-92da-4579-a907-65040ce0b3fc
*/
#[TestDox('White')]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync resistor-color

2 participants