Skip to content

Fix problems with baffling-birthdays #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennj merged 1 commit into from
Sep 20, 2026
Merged

Fix problems with baffling-birthdays #893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions exercises/practice/baffling-birthdays/baffling_birthdays.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ load bats-extra
generate=500
run bash baffling_birthdays.sh random_birthdates "$generate"
assert_success
num_output_dates=$( wc -w <<< "$output" )
num_output_dates=$( wc -w <<< "$output" | tr -d '[:space:]' )
assert_equal "$num_output_dates" "$generate"
}

Expand All @@ -104,7 +104,7 @@ load bats-extra
seen_leap=0
run bash baffling_birthdays.sh random_birthdates "$generate"
assert_success
read -ra output_dates <<< "$output"
read -d '' -ra output_dates < <(printf '%s\0' "$output")
for date in "${output_dates[@]}"; do
year=${date:0:4}
if (( year % 400 == 0 || (year % 4 == 0 && year % 100 != 0) )); then
Expand All @@ -120,7 +120,7 @@ load bats-extra
generate=500
run bash baffling_birthdays.sh random_birthdates "$generate"
assert_success
read -ra output_dates <<< "$output"
read -d '' -ra output_dates < <(printf '%s\0' "$output")
for date in "${output_dates[@]}"; do
month=${date:5:2}

Expand All @@ -135,7 +135,7 @@ load bats-extra
generate=500
run bash baffling_birthdays.sh random_birthdates "$generate"
assert_success
read -ra output_dates <<< "$output"
read -d '' -ra output_dates < <(printf '%s\0' "$output")
for date in "${output_dates[@]}"; do
day=${date:8}

Expand Down