Repository navigation
🐛 FIX: Keep a literal backslash before a space in link destinations - #468
Open
abhishekcpp007 wants to merge 1 commit into
Open
abhishekcpp007 wants to merge 1 commit into
abhishekcpp007 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an unbracketed link destination,
\followed by a space hitsbreak, so the backslash is dropped and the whole link fails to parse:Per CommonMark 6.1, a backslash before a non-punctuation character is literal, and the space just ends the destination. cmark and markdown-it 15 give the second output. This is the same one-line change as markdown-it/markdown-it#1188 (
pos++; continue), which landed after the 14.1.0 port.Added a fixture next to the existing CommonMark#493 case, covering an inline link, one with a title, and a reference definition.