Repository navigation
🐛 FIX: Reject url_schemes classes that aren't a list of str - #1230
Open
abhishekcpp007 wants to merge 1 commit into
Open
abhishekcpp007 wants to merge 1 commit into
abhishekcpp007 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
classescheck incheck_url_schemesjoins its two conditions withand, so it only fires when the value is not a list and has a non-string item. That never happens in practice:"classes": "external-gh"passes, and the link renders asclass="e x t e r n a l - g h""classes": [1, 2]passes, then the HTML writer crashes withAttributeError: 'int' object has no attribute 'startswith'Switched it to
or. Added a parametrized test inTestUrlSchemesfor a string, a list with an int, and a bare int, through bothMdParserConfigand the topmatter merge, plus one that a list of str still passes.