Prevent transient Service Status flicker - #2466
Merged
Merged
Conversation
Member
|
Thermo-nuclear code-quality pass found one straightforward structural simplification, fixed in 5cf3b0e: the redirector now coalesces the entire health-check/redirect operation behind one promise instead of coordinating separate health and navigation promises. This preserves the cache and concurrency behavior while removing state and the interleaving between phases.\n\nFocused verification on the exact PR head plus the fix:\n- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Every API response with status 0, 408, or 503 immediately navigated to Service Status. Several responses during rapid navigation could therefore repeatedly mount and unmount the authenticated layout. Each teardown closed the push socket, and a socket still connecting reported that intentional interruption through the normal error path.
Behavior and compatibility
An isolated transient API response no longer interrupts navigation when
/healthremains healthy. If the health probe also fails, the app performs one coalesced Service Status redirect and retains the current path, query string, and hash for recovery.Existing API contracts and push message formats are unchanged. Breaking changes: none.
Verification
npm run validate— 0 Svelte errors and 0 warningsnpm run test:unit— 48 files, 486 tests passednpm run build— passedeffect_update_depth_exceeded, maximum-update-depth, console, or page errors in the focused browser suite