Skip to content

chore: bring back replaces#3356

Merged
julienrbrt merged 1 commit into
mainfrom
julien/bump
Jun 12, 2026
Merged

chore: bring back replaces#3356
julienrbrt merged 1 commit into
mainfrom
julien/bump

Conversation

@julienrbrt

@julienrbrt julienrbrt commented Jun 12, 2026

Copy link
Copy Markdown
Member

Overview

Summary by CodeRabbit

  • Chores
    • Updated Go module configurations across multiple applications to reference internal project dependencies from local relative paths rather than remote sources. This improves build consistency, simplifies the local development environment, and ensures more reliable module resolution across the entire project during development, testing, and deployment phases.

@julienrbrt julienrbrt enabled auto-merge June 12, 2026 12:16
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR activates local module path resolution across three application modules. The replace directives in apps/evm/go.mod, apps/grpc/go.mod, and apps/testapp/go.mod are uncommented or added, mapping github.com/evstack/ev-node and its execution submodules to local relative filesystem paths rather than remote module versions.

Changes

Local Module Resolution

Layer / File(s) Summary
Enable local module paths across app modules
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod
Go replace directives are uncommented or added across all three app modules. apps/evm/go.mod and apps/grpc/go.mod activate multi-line replace blocks for their respective execution submodules, while apps/testapp/go.mod adds a single replace entry for the core ev-node module. All mappings point to local relative paths (../../ and ../../execution/{evm,grpc}) for local development builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • evstack/ev-node#3354: Adjusts the same apps/*/go.mod module resolution by toggling replace directives for github.com/evstack/ev-node and related execution modules.
  • evstack/ev-node#3276: Activates the same go.mod replace directives in apps/evm/go.mod, apps/grpc/go.mod, and apps/testapp/go.mod to map modules to local relative paths.
  • evstack/ev-node#3347: Activates the same go.mod replace directives across the same three app modules, mapping github.com/evstack/ev-node to local workspace paths.

Suggested reviewers

  • tac0turtle
  • chatton

Poem

🐰 A rabbit hops through modules and paths,
Unwrapping comments from code's behalf,
Local directories now come to play,
Where replace directives guide the way,
Building swift without remote delay! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty, containing only the template comments without any actual explanation, context, or linked issues. Add an Overview section explaining why the replace directives are being activated and what problem this solves.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: activating previously commented-out replace directives in Go module files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @julienrbrt's task in 33s —— View job


Code Review

  • Gather context and analyze changes
  • Review go.mod changes
  • Post findings

This PR re-enables replace directives in three go.mod files that were commented out in the prior commit (#3354 "prep apps"). The change is straightforward and correct.

Summary of changes:

File Directives restored
apps/evm/go.mod github.com/evstack/ev-node => ../../ and github.com/evstack/ev-node/execution/evm => ../../execution/evm
apps/grpc/go.mod github.com/evstack/ev-node => ../../ and github.com/evstack/ev-node/execution/grpc => ../../execution/grpc
apps/testapp/go.mod github.com/evstack/ev-node => ../../.

Observations:

  1. Correctness — restoring these directives is the right pattern for a Go monorepo. Without them, go build/go test inside each apps/ sub-module would resolve ev-node from the published registry instead of the local workspace, causing build failures or version skew during development.

  2. Minor inconsistency (non-blocking)apps/testapp/go.mod uses ../../. (trailing dot) while apps/evm and apps/grpc use ../../. Both resolve to the same directory; the trailing . is redundant but harmless. Fix this →

  3. go.sum removals — the four removed checksum entries across the .sum files are expected: with local replace directives active, Go no longer needs remote checksums for the replaced modules.

  4. No security, performance, or error-handling concerns — dependency graph changes only.

Overall this is a clean, low-risk maintenance change. The only suggestion is the optional trailing-dot cleanup in testapp/go.mod.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/testapp/go.mod`:
- Line 5: The replace directive uses a trailing dot ("replace
github.com/evstack/ev-node => ../../.") which is inconsistent with other
modules; update the replace line in the go.mod for the testapp to use the
canonical path ("../../") instead of "../../." so it matches apps/evm/go.mod and
apps/grpc/go.mod and removes the accidental trailing dot.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 23bdba3f-365c-4d16-ac7e-04ff92027bf6

📥 Commits

Reviewing files that changed from the base of the PR and between 72c1d4f and 6f594b9.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/grpc/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod

Comment thread apps/testapp/go.mod
go 1.25.8

// replace github.com/evstack/ev-node => ../../.
replace github.com/evstack/ev-node => ../../.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Inconsistent local path syntax in replace directive.

The path ../../. uses a trailing dot (explicit current-directory reference), while the equivalent directives in apps/evm/go.mod and apps/grpc/go.mod use the standard ../../ form. Both resolve identically, but the inconsistency could indicate a typo or copy-paste error and undermines maintainability.

Fix: Remove the trailing dot for consistency
-replace github.com/evstack/ev-node => ../../.
+replace github.com/evstack/ev-node => ../../
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
replace github.com/evstack/ev-node => ../../.
replace github.com/evstack/ev-node => ../../
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/testapp/go.mod` at line 5, The replace directive uses a trailing dot
("replace github.com/evstack/ev-node => ../../.") which is inconsistent with
other modules; update the replace line in the go.mod for the testapp to use the
canonical path ("../../") instead of "../../." so it matches apps/evm/go.mod and
apps/grpc/go.mod and removes the accidental trailing dot.

@github-actions

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJun 12, 2026, 12:22 PM

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.99%. Comparing base (72c1d4f) to head (6f594b9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3356      +/-   ##
==========================================
- Coverage   61.02%   60.99%   -0.03%     
==========================================
  Files         127      127              
  Lines       13879    13879              
==========================================
- Hits         8469     8466       -3     
- Misses       4485     4489       +4     
+ Partials      925      924       -1     
Flag Coverage Δ
combined 60.99% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 79b5b4f Jun 12, 2026
38 checks passed
@julienrbrt julienrbrt deleted the julien/bump branch June 12, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants