chore: bring back replaces#3356
Conversation
📝 WalkthroughWalkthroughThis PR activates local module path resolution across three application modules. The ChangesLocal Module Resolution
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @julienrbrt's task in 33s —— View job Code Review
This PR re-enables Summary of changes:
Observations:
Overall this is a clean, low-risk maintenance change. The only suggestion is the optional trailing-dot cleanup in |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/testapp/go.mod`:
- Line 5: The replace directive uses a trailing dot ("replace
github.com/evstack/ev-node => ../../.") which is inconsistent with other
modules; update the replace line in the go.mod for the testapp to use the
canonical path ("../../") instead of "../../." so it matches apps/evm/go.mod and
apps/grpc/go.mod and removes the accidental trailing dot.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 23bdba3f-365c-4d16-ac7e-04ff92027bf6
⛔ Files ignored due to path filters (3)
apps/evm/go.sumis excluded by!**/*.sumapps/grpc/go.sumis excluded by!**/*.sumapps/testapp/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
apps/evm/go.modapps/grpc/go.modapps/testapp/go.mod
| go 1.25.8 | ||
|
|
||
| // replace github.com/evstack/ev-node => ../../. | ||
| replace github.com/evstack/ev-node => ../../. |
There was a problem hiding this comment.
Inconsistent local path syntax in replace directive.
The path ../../. uses a trailing dot (explicit current-directory reference), while the equivalent directives in apps/evm/go.mod and apps/grpc/go.mod use the standard ../../ form. Both resolve identically, but the inconsistency could indicate a typo or copy-paste error and undermines maintainability.
Fix: Remove the trailing dot for consistency
-replace github.com/evstack/ev-node => ../../.
+replace github.com/evstack/ev-node => ../../📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| replace github.com/evstack/ev-node => ../../. | |
| replace github.com/evstack/ev-node => ../../ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/testapp/go.mod` at line 5, The replace directive uses a trailing dot
("replace github.com/evstack/ev-node => ../../.") which is inconsistent with
other modules; update the replace line in the go.mod for the testapp to use the
canonical path ("../../") instead of "../../." so it matches apps/evm/go.mod and
apps/grpc/go.mod and removes the accidental trailing dot.
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3356 +/- ##
==========================================
- Coverage 61.02% 60.99% -0.03%
==========================================
Files 127 127
Lines 13879 13879
==========================================
- Hits 8469 8466 -3
- Misses 4485 4489 +4
+ Partials 925 924 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Overview
Summary by CodeRabbit