Migrate HTTP server from Spark to Javalin#63
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4acfff035
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (path.equals("heartbeat") | ||
| && request.getHeader("x-http-method-override").equalsIgnoreCase("patch")) { |
There was a problem hiding this comment.
Guard heartbeat overrides by method and header
For any normal /heartbeat request with a tracked challenger but no X-HTTP-Method-Override header (including the documented GET /heartbeat flow), getHeader(...) returns null and this dereference throws. The Javalin runtime exception handler then returns 400 instead of the route's intended 204 response, and the heartbeat challenge cannot complete. Retain the POST guard and/or compare against a null-safe value.
Useful? React with 👍 / 👎.
Summary
Closes #53
Verification