fix(auth): persist rotated refresh token from tokenrefresh response - #220
Open
nezumi0627 wants to merge 1 commit into
Open
fix(auth): persist rotated refresh token from tokenrefresh response#220nezumi0627 wants to merge 1 commit into
nezumi0627 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthService.tryRefreshToken()discarded the rotated refresh token returned by the server.RefreshAccessTokenResponseexplicitly carries arefreshTokenfield (packages/types/line_types.ts:13446), and every login path persists the initial one (client/login.ts:110-111,base/login/mod.ts:163-164, 306, 618) — but the refresh path only updatedaccessTokenandexpire:If the server rotates the token (the reason the field exists), the next
tryRefreshToken()reuses a stale/invalidated token and dies with a refresh error — permanently breaking long-lived sessions that rely on periodic token refresh.Fix
Persist
RATR.refreshTokenwhen present, before writingexpire.Testing
New
mod.test.tsfollowing the existing stub-client pattern (relation/mod.test.ts):"rt-new".Full suite:
deno test --allow-allpasses.