Repository navigation
ci: align the fallback review prompt with the convergence policy - #352
Merged
Merged
Conversation
The fallback prompt (used only when fetching claude-review.md fails) said "Be strict: REQUEST_CHANGES for any issues found", contradicting the central prompt's failure-scenario and round-based convergence rules, so a fetch failure also silently switched review policy. Also drop pinned model versions from workflow comments. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBftoc1JCMLow9LDFZMADs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs your approval.
claude-code-actionskips review on any PR that modifies its own workflow file, andmainrequires one approving review. The bot can't approve this PR, so you'll have to.This was split out of #351.
claude-code-review.yml's fallback prompt is used only when fetchingclaude-review.mdfails. It said "Be strict: REQUEST_CHANGES for any issues found, only APPROVE if genuinely ready to merge". That contradicts the central prompt, which blocks only on Critical issues or on Important issues with a failure scenario, with round-based convergence. As a result, a fetch failure also silently changed the review policy. The new text: request changes only for Critical issues or for Important issues that name a concrete failure scenario; otherwise approve and post the rest as inline Suggestions.No functional change on the normal path: the central prompt is fetched as before.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LBftoc1JCMLow9LDFZMADs