Repository navigation
fix(report): advisory evaluators out of the summary; trace-rule causes counted as the budget does - #36
Merged
Conversation
…-rule causes as the budget does - The per-prompt Executive summary (and the header's mean score Δ, which averages its rows) picks the worst severity with ties toward the most negative effect size -- the order the hero panel and the narrative already used -- over gating evaluators only. A `blocking: false` evaluator speaks for a prompt only when nothing else scored it. On a real run the advisory `notes_watch` entry, satisfied by a target that called no tools, read as the prompt's "+9% improved" directly above a failed verdict. - `failure_categories` counts INVARIANT_VIOLATION the way max_invariant_violations does -- distinct examples with a blocking target violation -- instead of per row, advisory and shared breaks included. The "Top regression causes" panel and the insights built on it read 8 where the verdict read 5, and none of the 8 rows was a regression. - "Overall, by evaluator" tags an advisory entry's row the way the broken rules panel does, and says what a trace_invariants row measures. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35, found while rendering a real report with an advisory (
blocking: false)trace_invariantsentry. Three summary surfaces disagreed with the verdict; the rule checks themselves were correct.What was wrong
notes_watch+0.091 (advisory; the target "improved" by calling no tools)routing−0.091 (the gating evaluator, same sign as the hero tile's −0.30)notes_watchlooked like a gating evaluator; trace-rule rows had no "what this measures" lineChanges
reports/json.py:_build_executive_summaryorders by(severity, effect_size, p_corrected)— the ordering_headline_comparisonand the insights already use — over gating evaluators, falling back to advisory ones only for a prompt nothing else scored. Aggregate rows carryadvisoryso the template can tag them.analysis/policy.py:_failure_categoriescountsINVARIANT_VIOLATIONvia_invariant_violation_countsover blocking rows, so it can never disagree withmax_invariant_violations.reports/html.py+ template: advisory tag and akind_blurbfortrace_invariantsin the evaluator table.docs/configuration.md,DOCS.md,llms-full.txt) and CHANGELOG (Unreleased: amended Added bullet + a Changed entry for the tie-break).Tests
8 new tests (TDD, each watched red first):
TestInvariantFailureCategory(2) intest_policy.py,TestAdvisoryEvaluatorsInSummary(6) intest_reports.py.pytest: 2581 passed, 1 failed —test_bundle_shape.py::test_the_vendored_schema_matches_the_server_export. That failure is pre-existing and environmental (reproduced with this branch's changes stashed): it diffs the vendored bundle schema against the siblingevalshift-servercheckout, which is onmainwithout server #23'smax_invariant_violations. It passes once #23 is merged.ruff check,ruff format --check,mypy --strict,pre-commit run --all-filesall green.Release note: still blocked on server #23 deploying first (see #35).
🤖 Generated with Claude Code