Skip to content

use aiohttp in remote rollout processor to fix the open files issue#401

Merged
xzrderek merged 8 commits into
mainfrom
derekx/aiohttp
Jan 8, 2026
Merged

use aiohttp in remote rollout processor to fix the open files issue#401
xzrderek merged 8 commits into
mainfrom
derekx/aiohttp

Conversation

@xzrderek

@xzrderek xzrderek commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Note

Modernizes rollout execution and resource cleanup.

  • Remote rollout: migrate from requests to async aiohttp; introduce shared ClientSession with __call__ using async /init POST + timeout and draining; remove /status polling and rely on Fireworks tracing logs; add acleanup() and robust cleanup() that schedules session close when not in an async context
  • Base interface: add RolloutProcessor.acleanup() hook
  • Call sites: ensure await rollout_processor.acleanup() is invoked in evaluation_test_utils and gepa_trainer finally blocks
  • Tests: update to assert acleanup is awaited instead of only cleanup

Written by Cursor Bugbot for commit e913ca1. This will update automatically on new commits. Configure here.

@xzrderek
xzrderek enabled auto-merge (squash) January 7, 2026 23:27
Comment thread eval_protocol/pytest/remote_rollout_processor.py Outdated
@xzrderek
xzrderek disabled auto-merge January 7, 2026 23:29
Comment thread eval_protocol/pytest/remote_rollout_processor.py Outdated
Comment thread tests/pytest/test_utils.py Outdated
@xzrderek
xzrderek enabled auto-merge (squash) January 7, 2026 23:55
@xzrderek
xzrderek disabled auto-merge January 8, 2026 00:55
@xzrderek
xzrderek merged commit cf4fc4e into main Jan 8, 2026
17 of 18 checks passed
@xzrderek
xzrderek deleted the derekx/aiohttp branch January 8, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants