fix(ui): open librarium abs paths in the Web UI - #6
Open
Citizen4our wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Pasting a human Tabularium URL such as
/projects/turret/design/sas-architecture-tracker.mdon the Web UI dumped the session at the library root. The SPA only knew/entries/…and?open=; the catch-all routed every other path to/entries.Solution
Unknown paths are treated as librarium paths: a last segment containing
.opens preview via/entries/<dir>?open=<abs>, otherwise the path is a directory. Unit tests run in CI; Selenium covers document and directory deep links.Checklist
Test plan
https://tb-web…/projects/turret/design/sas-architecture-tracker.md— lands on/entries/…?open=…with preview, not/entries/entries— file list for that dir, no?open=cd ui && npm testMade with Cursor