Bael 7805 how to fix json io exception failed making field property accessible in gson - #19293
Open
MBuczkowski2025 wants to merge 14 commits into
Conversation
theangrydev
requested changes
Aug 13, 2026
Comment on lines
+24
to
+27
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> | ||
| <maven.compiler.release>17</maven.compiler.release> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
Collaborator
There was a problem hiding this comment.
Similar for these, can we rely on the parent for them?
Contributor
Author
There was a problem hiding this comment.
Without this setting, the build fails with a 'records are not supported in -source 8' error. Anyway, this fragment is shown in the tutorial. I'd leave it as it is.
Contributor
Author
There was a problem hiding this comment.
I mean, without the Java 17 setting. Encoding is removed
theangrydev
requested changes
Aug 13, 2026
theangrydev
requested changes
Aug 24, 2026
Comment on lines
+31
to
+34
| } catch (Exception e) { | ||
| log.info("Expected exception caught!"); | ||
| e.printStackTrace(); | ||
| } |
Collaborator
There was a problem hiding this comment.
e.printStackTrace() still counts as using System.out - if you want to log the exception put it as a parameter in the logging call - and the logging level should probably be error
Alternatively just let the main method throw exception so we don't have to handle this at all
Comment on lines
+17
to
+21
| String correctJson = "{" | ||
| + "\"name\":\"Java Conference\"," | ||
| + "\"numberOfParticipants\":500," | ||
| + "\"conferenceStart\":{\"year\":2026,\"month\":8,\"day\":17}" | ||
| + "}"; |
Collaborator
There was a problem hiding this comment.
(optional) since you're using a multiline format you can use of the """ syntax so we can avoid the need to escape the double quotes - if you do this then let's make similar changes for all the other JSON strings throughout the codebase
|
|
||
| @Test | ||
| void whenISOTextFormat_thenJsonSyntaxException() { | ||
|
|
Collaborator
There was a problem hiding this comment.
We have a few of these leading whitespace issues on several methods please remove those blank lines at the start and end of methods
theangrydev
requested changes
Aug 24, 2026
| } else { | ||
| log.info("Mode: [ Module Path ] - Module name: " + moduleName); | ||
| } | ||
| LocalDate excpectedDate = LocalDate.of(2026, 8, 17); |
Collaborator
There was a problem hiding this comment.
This is unused - let's remove it (and the import)
| Gson gson = new Gson(); | ||
| ConferencePojoWithDate result = gson.fromJson(correctJson, ConferencePojoWithDate.class); | ||
|
|
||
| LocalDate excpectedDate = LocalDate.of(2026, 8, 17); |
Collaborator
There was a problem hiding this comment.
Suggested change
| LocalDate excpectedDate = LocalDate.of(2026, 8, 17); | |
| LocalDate expectedDate = LocalDate.of(2026, 8, 17); |
Typo
Comment on lines
+1
to
+4
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <modelVersion>4.0.0</modelVersion> |
Collaborator
There was a problem hiding this comment.
The placeholder namespaces are fixed, but the xsi:schemaLocation attribute is still missing compared with the sibling modules
| opens gson.exception to com.google.gson; | ||
|
|
||
| exports gson.exception; | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
Missing newline at end of file
| import com.google.gson.Gson; | ||
| import com.google.gson.JsonIOException; | ||
|
|
||
| public class ModularGsonUnitTest { |
Collaborator
There was a problem hiding this comment.
Suggested change
| public class ModularGsonUnitTest { | |
| class ModularGsonUnitTest { |
| import com.google.gson.Gson; | ||
| import com.google.gson.GsonBuilder; | ||
|
|
||
| public class ModularGsonWithAdapterUnitTest { |
Collaborator
There was a problem hiding this comment.
Suggested change
| public class ModularGsonWithAdapterUnitTest { | |
| class ModularGsonWithAdapterUnitTest { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.