Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/dependency_injector/containers.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class Container:
def __init__(self) -> None: ...
def __deepcopy__(self, memo: Optional[Dict[str, Any]]) -> _Self: ...
def __setattr__(self, name: str, value: Union[Provider[Any], Any]) -> None: ...
def __getattr__(self, name: str) -> Provider[Any]: ...
def __delattr__(self, name: str) -> None: ...
def set_providers(self, **providers: Provider[Any]) -> None: ...
def set_provider(self, name: str, provider: Provider[Any]) -> None: ...
Expand Down Expand Up @@ -104,7 +103,11 @@ class Container:
@overload
def traverse(cls, types: Optional[Iterable[Type[TT]]] = None) -> Iterator[TT]: ...

class DynamicContainer(Container): ...
class DynamicContainer(Container):
# Providers are added dynamically by name, so attribute access must resolve
# to a Provider. This is intentionally absent from DeclarativeContainer,
# whose providers are declared statically (see issue #910).
def __getattr__(self, name: str) -> Provider[Any]: ...

class DeclarativeContainer(Container):
cls_providers: ClassVar[Dict[str, Provider[Any]]]
Expand Down
4 changes: 4 additions & 0 deletions tests/typing/dynamic_container.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@
# Test 6: to check base class
# NOTE: Using assignment to check base class instead of exact type
container6: containers.Container = containers.DynamicContainer()

# Test 7: dynamic attribute access resolves to a Provider (see issue #910)
container7 = containers.DynamicContainer()
assert_type(container7.some_provider, providers.Provider[Any])