chore(deps): bump go-ethereum to v1.17.5 - #144
Closed
barnabasbusa wants to merge 1 commit into
Closed
Conversation
Adapt execution mimicry to the eth protocol API changes in geth v1.17.5: - eth.NewPooledTransactionHashesPacket was split into version-specific Packet71/Packet72 types; use Packet71 since mimicry caps at eth/70 and the wire format (Types/Sizes/Hashes) is unchanged for <= eth/71. - eth.NewPeer gained a chainConfig parameter; pass nil like the existing txpool/blobpool arguments (geth nil-guards its only use).
![redpandabot[bot]](https://avatars.githubusercontent.com/in/3749543?s=60&v=4){kind=small}
Contributor
Author
|
Superseded by #143, which now carries the same mimicry fix plus the rest of the dependency group (CI green there). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates go-ethereum from v1.17.4 to v1.17.5 and adapts the execution mimicry package to the eth protocol API changes in that release.
Changes
eth.NewPooledTransactionHashesPacketwas split into version-specificNewPooledTransactionHashesPacket71/NewPooledTransactionHashesPacket72types (the 72 variant adds a custody bitmap for eth/72). Mimicry caps at eth/70 (maxETHProtocolVersion = 70), soPacket71is the correct type — the wire format (Types/Sizes/Hashes) is unchanged for <= eth/71. Updated the type alias and its test.eth.NewPeergained achainConfig *params.ChainConfigparameter. Passingnil, consistent with the existingniltxpool/blobpool arguments — geth nil-guards its only use of it (Amsterdam-aware receipt validation).go mod tidyside effects: c-kzg-4844 v2.1.6 -> v2.1.8, snappy v1.0.0 -> v1.0.1-0.20260716114414.Context
Downstream consumers can't take geth v1.17.5 until ethcore builds against it — e.g. dora's dependabot PR ethpandaops/dora#814 currently fails to compile because of this package (see also ethpandaops/dora#826 for the dora-side fix).
Testing
go build ./...,go vet ./...cleango test -race -p 1 -failfast -timeout 10m ./...passesgolangci-lint runreports the same pre-existing issues as master, none in touched files