feat: add check_http_metrics task for Prometheus metrics assertions#186
Merged
Conversation
Move the default maxResponseSize handling from the getter fallback to Validate(). This ensures a single source of truth for the default value and guarantees maxResponseSizeBytes is always populated after validation. - Validate() now sets DefaultMaxResponseSize if MaxResponseSize is empty - Simplified GetMaxResponseSizeBytes() to just return the value - Removed redundant fallback that duplicated the default Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add integration tests that mirror production usage by starting from
DefaultConfig(), calling Validate(), and executing the full task flow.
These tests verify the complete lifecycle and catch issues like missing
defaults that unit tests may miss.
New tests:
- TestIntegration_ValueMode: basic value assertion with label matching
- TestIntegration_DeltaMode: delta mode with baseline and evaluation
- TestIntegration_MultipleAssertions: multiple assertions on different metrics
Also updated test helpers to use decimal MB values (10,000,000) consistent
with humanize.ParseBytes("10MB") and fixed TestGetMaxResponseSizeBytes to
test the new Validate() behavior.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
barnabasbusa
added a commit
to ethpandaops/ethereum-package
that referenced
this pull request
May 29, 2026
## Summary Adds a full zkboost/EIP-8025 Kurtosis test configuration with Assertoor coverage. This introduces an 8-GPU isolated-verifier example that runs separate reth-zisk and ethrex-zisk zkboost prover instances, plus a shared verifier instance for both proof types. It also enables Assertoor and Spamoor for the run. The PR adds a new Assertoor test that checks zkboost Prometheus metrics for: - reth-zisk proof generation success - ethrex-zisk proof generation success - verifier success for both proof types ### Dependencies: 1) [check-http-metrics task](ethpandaops/assertoor#186) 2) [per instance zkVM validation](#1407) --------- Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
pk910
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_http_metricstask for evaluating assertions against Prometheus metrics endpointsFeatures
Assertion Modes:
value > 100)Metric Support:
Configurable Behaviors:
missingMetric/missingSeries:wait,fail, orpassresetBehavior:fail,rebaseline, orignore(COUNTER only)failOnCheckMiss: Fail immediately vs keep pollingcontinueOnPass: Keep monitoring after successSafety Features:
maxResponseSize)requestTimeout)Example Usage
Outputs
passedAssertionsfailedAssertionsvaluesdeltasbaselinesscrapeErrorsassertionErrorsFiles
pkg/tasks/check_http_metrics/config.gopkg/tasks/check_http_metrics/task.gopkg/tasks/check_http_metrics/task_test.gopkg/tasks/check_http_metrics/README.mdpkg/tasks/tasks.goTest Plan
go test -race)golangci-lint run --new-from-rev="origin/master")go build ./...)