fix(test-focil): omit inclusion list result for invalid payloads - #3445
Open
chugarchugarr wants to merge 1 commit into
Open
fix(test-focil): omit inclusion list result for invalid payloads#3445chugarchugarr wants to merge 1 commit into
chugarchugarr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3436.
Engine API payload metadata only has a meaningful
inclusionListSatisfiedresult when the payload itself is valid. The FOCIL filler previously carried the transition-tool result intoengine_newPayloadfixtures even when the sameBuiltBlockwas marked invalid.BuiltBlock.get_fixture_engine_new_payload()now:TrueandFalsefor valid payloads;Nonefor invalid payloads, as the Engine API requires.The focused regression covers all four valid/invalid and satisfied/unsatisfied combinations.
Verification
uv run pytest -q packages/testing/src/execution_testing/specs/tests/test_focil_payload_metadata.py— 4 passedgit diff --check— passedScope
Base
devnets/focil/0at23b0358c3513c8d22324faea66b41cec4b0b6446.