Skip to content

a handful of more signal/slot modernization #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eteran merged 1 commit into from
Jul 13, 2026
Merged

a handful of more signal/slot modernization #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/BinaryInfo/BinaryInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ QMenu *BinaryInfo::menu(QWidget *parent) {

if (!menu_) {
menu_ = new QMenu(tr("Binary Info"), parent);
menu_->addAction(tr("&Explore Binary Header"), this, SLOT(exploreHeader()));
menu_->addAction(tr("&Explore Binary Header"), this, &BinaryInfo::exploreHeader);
}

return menu_;
Expand Down
22 changes: 11 additions & 11 deletions src/DialogMemoryRegions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,20 @@ void DialogMemoryRegions::on_regions_table_customContextMenuRequested(const QPoi

QMenu menu;
auto access_menu = new QMenu(tr("Set Access"), this);
access_menu->addAction(tr("No Access"), this, SLOT(setAccessNone())); // ---
access_menu->addAction(tr("Read Only"), this, SLOT(setAccessR())); // r--
access_menu->addAction(tr("Write Only"), this, SLOT(setAccessW())); // -w-
access_menu->addAction(tr("Execute Only"), this, SLOT(setAccessX())); // --x
access_menu->addAction(tr("Read/Write"), this, SLOT(setAccessRW())); // rw-
access_menu->addAction(tr("Read/Execute"), this, SLOT(setAccessRX())); // r-x
access_menu->addAction(tr("Write/Execute"), this, SLOT(setAccessWX())); // -wx
access_menu->addAction(tr("Full Access"), this, SLOT(setAccessRWX())); // rwx
access_menu->addAction(tr("No Access"), this, &DialogMemoryRegions::setAccessNone); // ---
access_menu->addAction(tr("Read Only"), this, &DialogMemoryRegions::setAccessR); // r--
access_menu->addAction(tr("Write Only"), this, &DialogMemoryRegions::setAccessW); // -w-
access_menu->addAction(tr("Execute Only"), this, &DialogMemoryRegions::setAccessX); // --x
access_menu->addAction(tr("Read/Write"), this, &DialogMemoryRegions::setAccessRW); // rw-
access_menu->addAction(tr("Read/Execute"), this, &DialogMemoryRegions::setAccessRX); // r-x
access_menu->addAction(tr("Write/Execute"), this, &DialogMemoryRegions::setAccessWX); // -wx
access_menu->addAction(tr("Full Access"), this, &DialogMemoryRegions::setAccessRWX); // rwx

menu.addMenu(access_menu);
menu.addSeparator();
menu.addAction(tr("View in &CPU"), this, SLOT(viewInCpu()));
menu.addAction(tr("View in &Stack"), this, SLOT(viewInStack()));
menu.addAction(tr("View in &Dump"), this, SLOT(viewInDump()));
menu.addAction(tr("View in &CPU"), this, &DialogMemoryRegions::viewInCpu);
menu.addAction(tr("View in &Stack"), this, &DialogMemoryRegions::viewInStack);
menu.addAction(tr("View in &Dump"), this, &DialogMemoryRegions::viewInDump);
menu.exec(ui.regions_table->mapToGlobal(pos));
}

Expand Down
6 changes: 3 additions & 3 deletions src/RecentFileManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ void RecentFileManager::clear() {
if (menu_) {
menu_->clear();
menu_->addSeparator();
menu_->addAction(tr("Clear &Menu"), this, SLOT(clear()));
menu_->addAction(tr("Clear &Menu"), this, &RecentFileManager::clear);
}
}

Expand Down Expand Up @@ -129,13 +129,13 @@ void RecentFileManager::update() {
menu_->clear();

for (const auto &file : files_) {
if (QAction *const action = menu_->addAction(formatEntry(file), this, SLOT(itemSelected()))) {
if (QAction *const action = menu_->addAction(formatEntry(file), this, &RecentFileManager::itemSelected)) {
action->setData(QVariant::fromValue(file));
}
}

menu_->addSeparator();
menu_->addAction(tr("Clear &Menu"), this, SLOT(clear()));
menu_->addAction(tr("Clear &Menu"), this, &RecentFileManager::clear);
}
}

Expand Down