feat(socket): generalize Windows guards + add socket-option API

[finger563]

What & why

Two improvements to the socket component:

(a) _MSC_VER → _WIN32 guards. The Windows-specific code (Winsock2, closesocket vs close, WSAStartup, INVALID_SOCKET, ioctlsocket, SO_*/char* casts, WSAGetLastError) was guarded on _MSC_VER, which only covers the MSVC compiler. Switched every such guard to _WIN32 so MinGW / clang-cl Windows builds are covered too. Each guard was verified to be Windows-platform intent — none were MSVC-compiler-only pragmas.

Files: socket.hpp/socket.cpp, tcp_socket.hpp, socket_reactor.cpp, udp_socket.cpp, socket_msvc.hpp.

(b) Socket-option setters on the base Socket. Previously, setting SO_RCVBUF/SO_SNDBUF meant calling setsockopt() on the raw native handle (as our RTPS transport did). Added to espp::Socket:

bool set_option(int level, int option_name, const void *value, size_t size);
template <typename T> bool set_option(int level, int option_name, const T &value);
bool set_receive_buffer_size(size_t bytes);      // SO_RCVBUF
bool set_send_buffer_size(size_t bytes);          // SO_SNDBUF
bool set_reuse_address(bool enable);              // SO_REUSEADDR
std::optional<size_t> get_receive_buffer_size();  // getsockopt (bonus)

set_option handles the Windows const char* setsockopt cast and logs on failure. Then migrated the RTPS transport's manual 4 MB SO_RCVBUF setsockopt (EsppTransport.cpp) to socket->set_receive_buffer_size(...) — the only such call, and the Socket object was in scope.

Verification

Host lib builds clean (cmake -S lib ... --target install, exit 0) — this compiles both the socket sources and the RTPS transport (fragmentation on in the host profile, so the migrated path is exercised). The socket example is ESP-IDF-only, so the host lib is the compile check.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR broadens Windows platform support in the socket layer (MSVC-only → Windows-wide guards) and adds a safer, higher-level socket-option API to avoid direct native-handle setsockopt() usage in consumers.

Changes:

• Replaced _MSC_VER guards with _WIN32 across socket sources/headers to cover MinGW / clang-cl Windows builds.
• Added Socket::set_option(...) plus convenience helpers for common options (SO_RCVBUF/SO_SNDBUF/SO_REUSEADDR) and a get_receive_buffer_size() accessor.
• Migrated RTPS transport receive-buffer tuning to the new Socket API.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
components/socket/src/udp_socket.cpp	Windows guard generalized to _WIN32 for error handling paths.
components/socket/src/socket_reactor.cpp	Windows guard generalized to _WIN32 for close/nonblocking/select behavior.
components/socket/src/socket.cpp	Added socket-option API and generalized Winsock initialization/utility guards.
components/socket/include/tcp_socket.hpp	Generalized non-Windows include guard to _WIN32.
components/socket/include/socket_msvc.hpp	Header now enabled for all _WIN32 builds.
components/socket/include/socket.hpp	Introduced new Socket option APIs; generalized Windows typedef guard.
components/rtps_embedded/src/communication/EsppTransport.cpp	Replaced raw setsockopt call with Socket::set_receive_buffer_size.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

✅Static analysis result - no issues found! ✅