Skip to content

CI: make integration containers ephemeral (drop volumes) + log container output on boot timeout #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erseco merged 2 commits into from
Jul 7, 2026
Merged

CI: make integration containers ephemeral (drop volumes) + log container output on boot timeout #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b19871
Fix Moodle 5.1+ CI container boot: drop moodlehtml volume, log on tim…
erseco Jul 7, 2026
6a7d9d8
Drop the moodledata volume too: CI containers are ephemeral
erseco Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ upd: check-docker ensure-env
sleep 5; \
done; \
if [ $$ready -ne 1 ]; then \
echo "Moodle did not become ready in time."; \
echo "Moodle did not become ready in time. Recent container logs:"; \
docker compose logs --tail=80 moodle || true; \
exit 1; \
fi
@echo "Grace period: the login page can respond before Moodle's own"; \
Expand Down
5 changes: 0 additions & 5 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,8 @@ services:

ports:
- 80:8080
volumes:
- moodledata:/var/www/moodledata
- moodlehtml:/var/www/html
depends_on:
- postgres

volumes:
postgres: null
moodledata: null
moodlehtml: null